From 1eb453a027362392688e8718dfce7c5d44ca463f Mon Sep 17 00:00:00 2001 From: ZhangXiaoxu Date: Mon, 18 Feb 2019 22:56:43 +0800 Subject: [PATCH 0410/2944] nfs: fix xfstest generic/099 failed on nfsv3 commit ded52fbe7020a5696b0b0a0fdbf234e37bf16f94 upstream. After setxattr, the nfsv3 cached the acl which set by user. But at the backend, the shared file system (eg. ext4) will check the acl, if it can merged with mode, it won't add acl to the file. So, the nfsv3 cached acl is redundant. Don't 'set_cached_acl' when setxattr. Signed-off-by: ZhangXiaoxu Signed-off-by: Trond Myklebust Signed-off-by: Joseph Qi Reviewed-by: Xiaoguang Wang --- fs/nfs/nfs3acl.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/nfs/nfs3acl.c b/fs/nfs/nfs3acl.c index 9fce185..c5c3fc6 100644 --- a/fs/nfs/nfs3acl.c +++ b/fs/nfs/nfs3acl.c @@ -222,8 +222,6 @@ static int __nfs3_proc_setacls(struct inode *inode, struct posix_acl *acl, switch (status) { case 0: status = nfs_refresh_inode(inode, fattr); - set_cached_acl(inode, ACL_TYPE_ACCESS, acl); - set_cached_acl(inode, ACL_TYPE_DEFAULT, dfacl); break; case -EPFNOSUPPORT: case -EPROTONOSUPPORT: -- 1.8.3.1