From 61d6ab62ef24bfcd4a68361ac73a3db2169826e8 Mon Sep 17 00:00:00 2001 From: Jules Irenge Date: Mon, 6 Apr 2020 20:08:06 -0700 Subject: [PATCH 0947/2944] mm/compaction: add missing annotation for compact_lock_irqsave to #26255339 commit 77337edee7598d82fb5acf66cb91a5b3f0c46add upstream Sparse reports a warning at compact_lock_irqsave() warning: context imbalance in compact_lock_irqsave() - wrong count at exit The root cause is the missing annotation at compact_lock_irqsave() Add the missing __acquires(lock) annotation. Signed-off-by: Jules Irenge Signed-off-by: Andrew Morton Link: http://lkml.kernel.org/r/20200214204741.94112-6-jbi.octave@gmail.com Signed-off-by: Linus Torvalds Signed-off-by: Yang Shi Reviewed-by: Xunlei Pang --- mm/compaction.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/compaction.c b/mm/compaction.c index 6f7b36c..12289af 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -481,6 +481,7 @@ static bool test_and_set_skip(struct compact_control *cc, struct page *page, */ static bool compact_lock_irqsave(spinlock_t *lock, unsigned long *flags, struct compact_control *cc) + __acquires(lock) { /* Track if the lock is contended in async mode */ if (cc->mode == MIGRATE_ASYNC && !cc->contended) { -- 1.8.3.1