From 7cd07433e6b39f2205fae4dce1f50ba2e0bf07f6 Mon Sep 17 00:00:00 2001 From: Srinivas Pandruvada Date: Fri, 3 Jul 2020 14:18:55 +0800 Subject: [PATCH 1641/2944] ICX: platform/x86: ISST: Fix wrong unregister type fix #29131496 commit 6cc8f6598978b8f30e70bc12f28fbbc9e26227cc upstream The MMIO driver is not unregistering with the correct type with the ISST common core during module removal. This should be unregistered with ISST_IF_DEV_MMIO instead of ISST_IF_DEV_MBOX. Signed-off-by: Srinivas Pandruvada Signed-off-by: Andy Shevchenko Signed-off-by: Youquan Song Signed-off-by: Zelin Deng Acked-by: Artie Ding --- drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c b/drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c index f7266a1..bd3b867 100644 --- a/drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c +++ b/drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c @@ -126,7 +126,7 @@ static void isst_if_remove(struct pci_dev *pdev) struct isst_if_device *punit_dev; punit_dev = pci_get_drvdata(pdev); - isst_if_cdev_unregister(ISST_IF_DEV_MBOX); + isst_if_cdev_unregister(ISST_IF_DEV_MMIO); mutex_destroy(&punit_dev->mutex); } -- 1.8.3.1