From 907cd77698535e76db591e4fa093c0b3e21ca047 Mon Sep 17 00:00:00 2001 From: Shile Zhang Date: Tue, 30 Jun 2020 19:57:19 +0800 Subject: [PATCH 1862/2944] alinux: panic: change the default value of crash_kexec_post_notifiers to true fix #29056122 commit 'fbb2f06ef013' ("pvpanic: add crash loaded event") introduce new pvpanic event 'PVPANIC_CRASH_LOADED', it make the qemu on host can get info that if the guest already handle the panic by kdump or not. But if the guest enabled the kdump, it will not post the panic event by default unless the parameter 'crash_kexec_post_notifiers' is given. So, its better to set the default value of this parameter to true, to avoid it missed in case of kdump enabled. If user want disable the event notification, the parameter 'crash_kexec_post_notifiers=N' should be given. Signed-off-by: Shile Zhang Acked-by: Joseph Qi --- Documentation/admin-guide/kernel-parameters.txt | 4 +++- kernel/panic.c | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt index 369307d..5587ee4 100644 --- a/Documentation/admin-guide/kernel-parameters.txt +++ b/Documentation/admin-guide/kernel-parameters.txt @@ -3187,13 +3187,15 @@ panic_on_warn panic() instead of WARN(). Useful to cause kdump on a WARN(). - crash_kexec_post_notifiers + crash_kexec_post_notifiers= Run kdump after running panic-notifiers and dumping kmsg. This only for the users who doubt kdump always succeeds in any situation. Note that this also increases risks of kdump failure, because some panic notifiers can make the crashed kernel more unstable. + Format: (1/Y/y=enable, 0/N/n=disable) + default: enabled parkbd.port= [HW] Parallel port number the keyboard adapter is connected to, default is 0. diff --git a/kernel/panic.c b/kernel/panic.c index 8138a676..26038cf 100644 --- a/kernel/panic.c +++ b/kernel/panic.c @@ -40,7 +40,7 @@ static int pause_on_oops; static int pause_on_oops_flag; static DEFINE_SPINLOCK(pause_on_oops_lock); -bool crash_kexec_post_notifiers; +bool crash_kexec_post_notifiers = true; int panic_on_warn __read_mostly; int panic_timeout = CONFIG_PANIC_TIMEOUT; -- 1.8.3.1