From 3af6e924e6fc016ebf64007815aca88545b7afeb Mon Sep 17 00:00:00 2001 From: Hongbo Yao Date: Tue, 2 Apr 2019 22:19:36 +0800 Subject: [PATCH 2853/2944] openEuler: mpam: fix potential resource leak in mpam_domains_init commit 7d23ff6d37d3b32f0fb44880e4dc4c037a86aa37 openEuler-1.0 euler inclusion category: bugfix bugzilla: 13254 CVE: NA --------------------------- Variable "d" going out of scope leaks the storage it points to. Signed-off-by: Hongbo Yao Reviewed-by: Xie XiuQi Signed-off-by: Yang Yingliang Signed-off-by: Xin Hao Reviewed-by: Baolin Wang --- arch/arm64/kernel/mpam.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/arm64/kernel/mpam.c b/arch/arm64/kernel/mpam.c index d18868d..eb9e382 100644 --- a/arch/arm64/kernel/mpam.c +++ b/arch/arm64/kernel/mpam.c @@ -1219,8 +1219,10 @@ static void mpam_domains_init(struct resctrl_resource *r) d->cpus_list = n->cpus_list; d->ctrl_val = kmalloc_array(rr->num_partid, sizeof(*d->ctrl_val), GFP_KERNEL); - if (!d->ctrl_val) + if (!d->ctrl_val) { + kfree(d); return; + } list_add_tail(&d->list, add_pos); -- 1.8.3.1