From c6feb1939e495ac7b331065be0eeaa049e8a8615 Mon Sep 17 00:00:00 2001 From: Xie XiuQi Date: Tue, 9 Jul 2019 23:44:37 +0800 Subject: [PATCH 2865/2944] openEuler: arm64/mpam: use snprintf instead of sprintf commit 5942ec9b5dafaec45770276f0eae7f6b457cd4d7 openEuler-1.0 hulk inclusion category: bugfix bugzilla: 16633 CVE: NA snprintf is more safe than sprintf, it is recommended to use snprintf. Signed-off-by: Xie XiuQi Reviewed-by: Yang Yingliang Signed-off-by: Yang Yingliang Signed-off-by: Xin Hao Reviewed-by: Baolin Wang --- arch/arm64/kernel/mpam_ctrlmon.c | 2 +- fs/resctrlfs.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/kernel/mpam_ctrlmon.c b/arch/arm64/kernel/mpam_ctrlmon.c index 02623c1..86e50fd 100644 --- a/arch/arm64/kernel/mpam_ctrlmon.c +++ b/arch/arm64/kernel/mpam_ctrlmon.c @@ -415,7 +415,7 @@ static int mkdir_mondata_subdir(struct kernfs_node *parent_kn, md.u.partid = prgrp->closid; md.u.pmg = prgrp->mon.rmid; - sprintf(name, "mon_%s_%02d", r->name, d->id); + snprintf(name, sizeof(name), "mon_%s_%02d", r->name, d->id); kn = __kernfs_create_file(parent_kn, name, 0444, GLOBAL_ROOT_UID, GLOBAL_ROOT_GID, 0, &kf_mondata_ops, md.priv, NULL, NULL); diff --git a/fs/resctrlfs.c b/fs/resctrlfs.c index 6277cb0..2bba5b7 100644 --- a/fs/resctrlfs.c +++ b/fs/resctrlfs.c @@ -199,7 +199,7 @@ static int resctrl_group_create_info_dir(struct kernfs_node *parent_kn) for_each_resctrl_resource(r) { if (r->mon_enabled) { fflags = r->fflags | RF_MON_INFO; - sprintf(name, "%s_MON", r->name); + snprintf(name, sizeof(name), "%s_MON", r->name); ret = resctrl_group_mkdir_info_resdir(r, name, fflags); if (ret) goto out_destroy; -- 1.8.3.1